Conversation
jfeingold35
requested changes
Sep 9, 2026
| @@ -0,0 +1 @@ | |||
| export { default } from 'eslint-config-salesforce-typescript'; | |||
Contributor
There was a problem hiding this comment.
This isn't equivalent to the old one. We also need to be using sf-plugin/recommended and xo-react.
Author
There was a problem hiding this comment.
I can't add xo-react back because it depends on eslint-plugin-react which does not have a version that supports eslint 10. I tried updating xo-react to the latest version, but eslint-plugin-react was still causing problems.
Author
|
Closing since we can't upgrade to eslint v10 (flat config) and keep |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Upgrade
@salesforce/dev-scriptsto v14,typescriptto v6, andeslintto v10 with flat config (eslint.config.mjs + eslint-suppressions.json), replacing the legacy .eslintrc.cjs setup. Remove redundant type assertions and stale eslint-disable comments surfaced by the new rules.What issues does this PR fix or reference?
@W-23983670@